Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVY-998][THRIF] Support connecting to an existing sessions using session name #445

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

askhatri
Copy link
Contributor

@askhatri askhatri commented Apr 22, 2024

Support connecting to an existing session using the session name via Thrift Server.

What changes were proposed in this pull request?

JIRA: https://issues.apache.org/jira/browse/LIVY-998

The Thrift Server can set the session name, but it cannot use an existing session name and connect to it. Added the fix to use an existing session name and connect to it via Thrift Server.

How was this patch tested?

Created a session using session name:

curl --no-progress-meter -X POST -H "Content-Type: application/json" --data '{"kind": "spark", "name": "sesssionName"}' http://HOST:PORT/sessions

Connected to the existing session via Thrift Server using:

$ beeline -u "jdbc:hive2://HOST:PORT/?livy.session.name=sesssionName"

@askhatri askhatri changed the title [LIVY-998][THRIFT SERVER] Support connecting to an existing sessions using session name [LIVY-998][THRIF] Support connecting to an existing sessions using session name Apr 22, 2024
Copy link
Contributor

@gyogal gyogal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, Asif! A minor nitpick I have is there is a typo in the commit message, but that can updated fixed when the change is merged.

@askhatri
Copy link
Contributor Author

askhatri commented Jun 4, 2024

Thank you @gyogal , I have updated the commit message now.

@gyogal gyogal merged commit 728fcf0 into apache:master Jun 10, 2024
3 checks passed
@askhatri askhatri deleted the LIVY-998 branch June 24, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants